rondagostino commented on a change in pull request #10694:
URL: https://github.com/apache/kafka/pull/10694#discussion_r633598560



##########
File path: tests/kafkatest/services/security/security_config.py
##########
@@ -258,8 +259,10 @@ def enable_sasl(self):
     def enable_ssl(self):
         self.has_ssl = True
 
-    def enable_security_protocol(self, security_protocol):
+    def enable_security_protocol(self, security_protocol, sasl_mechanism = 
None):

Review comment:
       Good catch!  I missed leveraging this, and it results in 
`sasl.enabled.mechanisms=` (i.e. blank) on the first of the two rolls.  The 
test was still passing, but I think that's just luck.  I've fixed it in 
`kafka.py` -- we now pass in the SASL mechanism, and we are now seeing 
`sasl.enabled.mechanisms=PLAIN` as expected.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to