cmccabe commented on pull request #10255: URL: https://github.com/apache/kafka/pull/10255#issuecomment-844497580
Thanks for looking at this. The issue that I see with sharing channels (really sockets) in this way is that we don't want the broker heartbeat to get delayed by something else. If the heartbeat gets delayed too long, the consequences could be really bad. I think what we should do here is get rid of head-of-line blocking for Kafka RPCs, so that they can be done in parallel. Really, the main reason why we still have head-of-line blocking is because of the difficulty of moving the producer and consumer off of that model. So we could get rid of HOL blocking for all requests except produce and consume without too many changes to the code, I think. I think we need to fix the HOL blocking problem before we start consolidating channels, to avoid regressions in functionality. cc @ijuma @hachikuji @abbccdda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
