mimaison commented on a change in pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#discussion_r636816944
##########
File path:
core/src/test/scala/unit/kafka/integration/MetricsDuringTopicCreationDeletionTest.scala
##########
@@ -70,12 +70,12 @@ class MetricsDuringTopicCreationDeletionTest extends
KafkaServerTestHarness with
@Test
def testMetricsDuringTopicCreateDelete(): Unit = {
- // For UnderReplicatedPartitions, because of
https://issues.apache.org/jira/browse/KAFKA-4605
+ // For UnderReplicatedPartitions, because of KAFKA-4605
Review comment:
Why are we removing the links?
##########
File path:
core/src/test/scala/unit/kafka/integration/MetricsDuringTopicCreationDeletionTest.scala
##########
@@ -116,9 +116,9 @@ class MetricsDuringTopicCreationDeletionTest extends
KafkaServerTestHarness with
running = false;
thread.join
- assert(offlinePartitionsCount==0, "OfflinePartitionCount not 0: "+
offlinePartitionsCount)
- assert(preferredReplicaImbalanceCount==0, "PreferredReplicaImbalanceCount
not 0: " + preferredReplicaImbalanceCount)
- assert(underReplicatedPartitionCount==0, "UnderReplicatedPartitionCount
not 0: " + underReplicatedPartitionCount)
+ assert(offlinePartitionsCount==0, "Expect OfflinePartitionCount to be 0,
but got: "+ offlinePartitionsCount)
Review comment:
We can use string interpolation here:
```
assert(offlinePartitionsCount==0, s"Expect OfflinePartitionCount to be 0,
but got: $offlinePartitionsCount")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
