vvcephei commented on a change in pull request #10507:
URL: https://github.com/apache/kafka/pull/10507#discussion_r637033886
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/ValueJoiner.java
##########
@@ -23,9 +23,9 @@
* record-pair of a {@link KStream}-{@link KStream}, {@link KStream}-{@link
KTable}, or {@link KTable}-{@link KTable}
* join.
*
- * @param <V1> first value type
- * @param <V2> second value type
- * @param <VR> joined value type
Review comment:
Also here: it doesn't seem strictly necessary to rename the generic
parameters as part of this PR.
Specifically, funny story: these params used to be called `V` and `V1`, and
we renamed them to `V1` and `V2` because we thought it made more sense :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
