kowshik commented on a change in pull request #10742:
URL: https://github.com/apache/kafka/pull/10742#discussion_r637344863
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2226,12 +2231,14 @@ object Log extends Logging {
* @param topicPartition The topic partition
* @param logDirFailureChannel The LogDirFailureChannel to asynchronously
handle log dir failure
* @param recordVersion The record version
+ * @param logPrefix The logging prefix
* @return The new LeaderEpochFileCache instance (if created), none otherwise
*/
def maybeCreateLeaderEpochCache(dir: File,
topicPartition: TopicPartition,
logDirFailureChannel: LogDirFailureChannel,
- recordVersion: RecordVersion):
Option[LeaderEpochFileCache] = {
+ recordVersion: RecordVersion,
+ logPrefix: String):
Option[LeaderEpochFileCache] = {
Review comment:
Introducing a default value can lead to programming error, because we
could forget to pass it when it is really needed to be passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
