ableegoldman commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r638396898
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -387,18 +422,18 @@ public synchronized void cleanRemovedTasks(final long
cleanupDelayMs) {
}
private void cleanRemovedTasksCalledByCleanerThread(final long
cleanupDelayMs) {
- for (final File taskDir : listNonEmptyTaskDirectories()) {
Review comment:
Just want to call this out since it's a change in behavior unrelated to
this PR -- actually just something we could/should have cleaned up after
removing the lock/file based locking. Previously we couldn't ever delete empty
task dirs by cleaner thread (due to that Windows bug), now we can, so we should
not exclude empty dirs here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
