dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r646056035



##########
File path: core/src/test/java/kafka/test/MockController.java
##########
@@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource 
resource,
     }
 
     @Override
-    public CompletableFuture<AlterPartitionReassignmentsResponseData>
-            alterPartitionReassignments(AlterPartitionReassignmentsRequestData 
request) {
+    public CompletableFuture<AlterPartitionReassignmentsResponseData> 
alterPartitionReassignments(AlterPartitionReassignmentsRequestData request) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public CompletableFuture<ListPartitionReassignmentsResponseData>
-            listPartitionReassignments(ListPartitionReassignmentsRequestData 
request) {
+    public CompletableFuture<ListPartitionReassignmentsResponseData> 
listPartitionReassignments(ListPartitionReassignmentsRequestData request) {
         throw new UnsupportedOperationException();
     }
 
     @Override
     public CompletableFuture<Map<ConfigResource, ApiError>> legacyAlterConfigs(
-            Map<ConfigResource, Map<String, String>> newConfigs, boolean 
validateOnly) {
+                                                                               
Map<ConfigResource, Map<String, String>> newConfigs, boolean validateOnly) {

Review comment:
       case 1. If you put the parameters of this method on the same line as the 
method name and run formatter: remains one line.
   case 2. If you put the parameters separated and run formatter: broken. 
(below)
   
![20210606-101022](https://user-images.githubusercontent.com/2375128/120909374-72a62680-c6af-11eb-86e9-b09fa515c684.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to