[GitHub] [kafka] showuon commented on a change in pull request #10828: MINOR: Only log overridden topic configs during topic creation

[GitBox]

showuon commented on a change in pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#discussion_r646095921



##########
File path: core/src/test/scala/unit/kafka/log/LogConfigTest.scala
##########
@@ -162,6 +162,21 @@ class LogConfigTest {
     assertNull(nullServerDefault)
   }
 
+  @Test
+  def testOverriddenConfigsAsLoggableString(): Unit = {
+    val kafkaProps = TestUtils.createBrokerConfig(nodeId = 0, zkConnect = "")
+    kafkaProps.put("unknown.broker.password.config", "aaaaa")
+    kafkaProps.put(KafkaConfig.SslKeyPasswordProp, "somekeypassword")

Review comment:
       Could we add a line with the same setting as overridden one, but not the 
same value, so that we can verify the overridden value will be outputted? Ex:
   add this line
   `kafkaProps.put(LogConfig.MinInSyncReplicasProp, "1")`
   then, we already have
   ` topicOverrides.setProperty(LogConfig.MinInSyncReplicasProp, "2")`
   
   So, we can assert the log is output `min.insync.replicas=2`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org