[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

[GitBox]

cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r646435466



##########
File path: core/src/test/java/kafka/test/MockController.java
##########
@@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource 
resource,
     }
 
     @Override
-    public CompletableFuture<AlterPartitionReassignmentsResponseData>
-            alterPartitionReassignments(AlterPartitionReassignmentsRequestData 
request) {
+    public CompletableFuture<AlterPartitionReassignmentsResponseData> 
alterPartitionReassignments(AlterPartitionReassignmentsRequestData request) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public CompletableFuture<ListPartitionReassignmentsResponseData>
-            listPartitionReassignments(ListPartitionReassignmentsRequestData 
request) {
+    public CompletableFuture<ListPartitionReassignmentsResponseData> 
listPartitionReassignments(ListPartitionReassignmentsRequestData request) {
         throw new UnsupportedOperationException();
     }
 
     @Override
     public CompletableFuture<Map<ConfigResource, ApiError>> legacyAlterConfigs(
-            Map<ConfigResource, Map<String, String>> newConfigs, boolean 
validateOnly) {
+                                                                               
Map<ConfigResource, Map<String, String>> newConfigs, boolean validateOnly) {

Review comment:
       After that, I think, we can merge. Besides the import order changes, you 
kept the just a few formatting style changes, which I think is good. If 
somebody does not agree, we can make it even less invasive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org