jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r648811500
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -254,8 +255,14 @@ public synchronized int sendFetches() {
for (Map.Entry<Node, FetchSessionHandler.FetchRequestData> entry :
fetchRequestMap.entrySet()) {
final Node fetchTarget = entry.getKey();
final FetchSessionHandler.FetchRequestData data = entry.getValue();
+ final short maxVersion;
+ if (!data.canUseTopicIds()) {
+ maxVersion = (short) 12;
+ } else {
+ maxVersion = ApiKeys.FETCH.latestVersion();
+ }
final FetchRequest.Builder request = FetchRequest.Builder
- .forConsumer(this.maxWaitMs, this.minBytes, data.toSend())
+ .forConsumer(maxVersion, this.maxWaitMs, this.minBytes,
data.toSend(), metadata.topicIds())
Review comment:
I noticed that I get topic IDs from metadata here and in the replica
fetcher thread, I get from the metadata cache. I don't think it is a big deal
since we add to the fetchData using the same source, but it might make sense to
use FetchRequestData's topicIds() instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
