showuon commented on a change in pull request #10872:
URL: https://github.com/apache/kafka/pull/10872#discussion_r650627746
##########
File path: docs/upgrade.html
##########
@@ -25,6 +25,8 @@ <h5><a id="upgrade_300_notable"
href="#upgrade_300_notable">Notable changes in 3
<li>A number of implementation dependency jars are <a
href="https://github.com/apache/kafka/pull/10203";>now available in the runtime
classpath
instead of compile and runtime classpaths</a>. Compilation errors
after the upgrade can be fixed by adding the missing dependency jar(s)
explicitly
or updating the application not to use internal classes.</li>
+ <li>The default value for the consumer configuration
<code>session.timeout.ms</code> was increased from 10s to 45s. See
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+session+timeout";>KIP-735</a>
for more details.</li>
Review comment:
Aha, good catch to add 45s default session timeout!
##########
File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
##########
@@ -145,69 +145,35 @@ class KafkaConfigTest {
@Test
def testAdvertiseDefaults(): Unit = {
- val port = "9999"
+ val port = 9999
val hostName = "fake-host"
-
- val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect)
- props.remove(KafkaConfig.ListenersProp)
- props.put(KafkaConfig.HostNameProp, hostName)
- props.put(KafkaConfig.PortProp, port)
+ val props = new Properties()
+ props.put(KafkaConfig.BrokerIdProp, "1")
+ props.put(KafkaConfig.ZkConnectProp, "localhost:2181")
+ props.put(KafkaConfig.ListenersProp, s"PLAINTEXT://$hostName:$port")
Review comment:
Nice tests update!
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -480,7 +480,8 @@ class KafkaServer(
endpoint
)
- val jmxPort = System.getProperty("com.sun.management.jmxremote.port",
"-1").toInt
+ val jmxPort = System.getProperty("com.sun.management.jmxremote.port", "
+ ").toInt
Review comment:
This should be typo. It caused **compile error**!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
