kpatelatwork commented on a change in pull request #10822:
URL: https://github.com/apache/kafka/pull/10822#discussion_r651298044



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
##########
@@ -186,6 +192,10 @@
     private short currentProtocolVersion;
     private short backoffRetries;
 
+    // visible for testing
+    // The pending restart requests for the connectors;
+    final NavigableSet<RestartRequest> pendingRestartRequests = new 
TreeSet<>();

Review comment:
       no particular reason, TreeSet was a NavigableSet implementation that 
came to my mind.  But I like your above idea of using a map and simplifying the 
code, Let me work on it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to