jsancio commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r651374491
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -85,6 +85,20 @@ public OffsetAndEpoch snapshotId() {
return snapshot.snapshotId();
}
+ /**
+ * Returns the last log offset which is represented in the snapshot.
+ */
+ public long lastOffsetFromLog() {
Review comment:
One of the users of this API had some confusion with this offset and the
offsets return in the `Batch` by the `SnapshotReader` iterator. I wanted to
make it clear that this offset and epoch refers to the offset and epoch found
in the `ReplicatedLog` or `handleCommit`.
While the offsets reported by the `Batch` for the `SnapshotReader` iterator
are unrelated to the log's offsets.
How about `lastContainedLogOffset` and `lastContainedLogEpoch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
