jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r651985270
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -70,6 +71,7 @@ object FetchSession {
* localLogStartOffset is the log start offset of the partition on this
broker.
*/
class CachedPartition(val topic: String,
+ val topicId: Uuid,
Review comment:
I thought about this, and originally we compared the topic IDs in the
session by grabbing cached partitions and comparing to the IDs in the request.
Since we have a new mechanism (the topic ID map) we may no longer need to do
this and I can add the ID to the hashcode and equals methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
