[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

[GitBox]

skaundinya15 commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r655921459



##########
File path: 
clients/src/main/java/org/apache/kafka/common/requests/FindCoordinatorRequest.java
##########
@@ -70,7 +75,7 @@ public AbstractResponse getErrorResponse(int throttleTimeMs, 
Throwable e) {
             response.setThrottleTimeMs(throttleTimeMs);
         }
         Errors error = Errors.forException(e);
-        return FindCoordinatorResponse.prepareResponse(error, Node.noNode());
+        return FindCoordinatorResponse.prepareOldResponse(error, 
Node.noNode());

Review comment:
       Why do we call the `prepareOldResponse` in `getErrorResponse`? Should we 
be doing a version check here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org