hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656448517
########## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ########## @@ -2250,7 +2252,34 @@ private Long append(int epoch, List<T> records, boolean isAtomic) { @Override public void resign(int epoch) { - throw new UnsupportedOperationException(); + if (epoch < 0) { Review comment: I consider epoch 0 to be a valid epoch even though no leader could have been elected in this epoch. Therefore a resignation from epoch 0 is treated as a no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org