ccding commented on a change in pull request #10763:
URL: https://github.com/apache/kafka/pull/10763#discussion_r659094582
##########
File path: core/src/main/scala/kafka/log/LogLoader.scala
##########
@@ -106,7 +158,14 @@ object LogLoader extends Logging {
loadSegmentFiles(params)
})
- completeSwapOperations(swapFiles, params)
+ // Forth pass: rename remaining index swap files. They must be left due to
a broker crash when
Review comment:
We have renamed all `.log.swap` files and their corresponding index swap
files. If there is a single .index.swap file, it is not renamed previously in
the recovery process. A single .index.swap file could happen if it crashed in
the middle of this line:
https://github.com/apache/kafka/blob/bd668e90c6992e7a1f23274aab37d186d6a4b560/core/src/main/scala/kafka/log/Log.scala#L2381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
