guozhangwang commented on pull request #10930: URL: https://github.com/apache/kafka/pull/10930#issuecomment-870078185
> @guozhangwang With Errors.NONE, we throw OffsetOutOfRangeException in the follower when attempting to update follower's start offset based on the leader's start offset returned in the response: I see, I thought you meant there are some conditions on the follower's side that still can protect us from not capturing this error. Now that I realized this condition may or may not hit really, but in either case it's bad: 1. If it is not hit, we would ended up not capturing this error and proceed as if nothing went wrong. 2. If it is hit, we throw OOO to capture, on follower's side, but also moved the partition to failed state and we would not be able to recover from that state. If my understanding here is correct, I think I can go ahead and merge the PR. BTW could you re-trigger the unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
