hachikuji commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r660178840
########## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteTopicsResult.java ########## @@ -30,24 +31,62 @@ */ @InterfaceStability.Evolving public class DeleteTopicsResult { - final Map<String, KafkaFuture<Void>> futures; + private Map<String, KafkaFuture<Void>> nameFutures; + private Map<Uuid, KafkaFuture<Void>> topicIdFutures; - protected DeleteTopicsResult(Map<String, KafkaFuture<Void>> futures) { - this.futures = futures; + protected DeleteTopicsResult() {} Review comment: Yeah, right. As long as the constructor is private, you can ensure one of them must be null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org