kpatelatwork commented on a change in pull request #10822:
URL: https://github.com/apache/kafka/pull/10822#discussion_r660864346
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##########
@@ -210,6 +211,15 @@ public void onDeletion(ConnectorTaskId id) {
statusBackingStore.put(new TaskStatus(id, TaskStatus.State.DESTROYED,
workerId, generation()));
}
+ public void onRestart(String connector) {
Review comment:
I added the missing documentation.
I didn't add the onRestart method to Listener because it didn't felt it
should be a part of the task lifecycle controlled by the worker. Earlier the
method was called recordRestart but based on a review comment, it was renamed
it to onRestart, Do you think we should rename it back to recordRestart. The
original intent of this method was to just record the state change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
