spena commented on a change in pull request #10917:
URL: https://github.com/apache/kafka/pull/10917#discussion_r661642934
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##########
@@ -183,15 +195,27 @@ public void process(final K key, final V1 value) {
@SuppressWarnings("unchecked")
private void emitNonJoinedOuterRecords(final
WindowStore<KeyAndJoinSide<K>, LeftOrRightValue> store) {
+ if (sharedTimeTracker.minTime >= sharedTimeTracker.streamTime -
joinAfterMs - joinGraceMs) {
+ return;
+ }
+ if (context.currentSystemTimeMs() <
sharedTimeTracker.nextTimeToEmit) {
Review comment:
Could you add a comment why we're using the system time instead of
stream time to emit the results? I think I know why, but it would be good to
have it here for future understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
