cmccabe commented on a change in pull request #10949: URL: https://github.com/apache/kafka/pull/10949#discussion_r661849874
########## File path: metadata/src/main/java/org/apache/kafka/image/ClientQuotaImage.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.image; + +import org.apache.kafka.common.message.DescribeClientQuotasResponseData.ValueData; +import org.apache.kafka.common.metadata.ClientQuotaRecord; +import org.apache.kafka.common.metadata.ClientQuotaRecord.EntityData; +import org.apache.kafka.common.quota.ClientQuotaEntity; +import org.apache.kafka.server.common.ApiMessageAndVersion; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map.Entry; +import java.util.Map; +import java.util.Objects; +import java.util.function.Consumer; +import java.util.stream.Collectors; + +import static org.apache.kafka.common.metadata.MetadataRecordType.CLIENT_QUOTA_RECORD; + + +/** + * Represents a quota for a client entity in the metadata image. + * + * This class is thread-safe. + */ +public final class ClientQuotaImage { + public final static ClientQuotaImage EMPTY = new ClientQuotaImage(Collections.emptyMap()); + + private final Map<String, Double> quotas; + + public ClientQuotaImage(Map<String, Double> quotas) { + this.quotas = quotas; + } + + Map<String, Double> quotas() { + return quotas; + } + + public void write(ClientQuotaEntity entity, Consumer<List<ApiMessageAndVersion>> out) throws IOException { + List<ApiMessageAndVersion> records = new ArrayList<>(); + for (Entry<String, Double> entry : quotas.entrySet()) { + records.add(new ApiMessageAndVersion(new ClientQuotaRecord(). + setEntity(entityToData(entity)). + setKey(entry.getKey()). + setValue(entry.getValue()). + setRemove(false), + CLIENT_QUOTA_RECORD.highestSupportedVersion())); + } + out.accept(records); + } + + public static List<EntityData> entityToData(ClientQuotaEntity entity) { + List<EntityData> entityData = new ArrayList<>(entity.entries().size()); + for (Entry<String, String> entry : entity.entries().entrySet()) { + entityData.add(new EntityData(). + setEntityType(entry.getKey()). + setEntityName(entry.getValue())); + } + return entityData; + } + + public static ClientQuotaEntity dataToEntity(List<EntityData> entityData) { + Map<String, String> entries = new HashMap<>(); + for (EntityData data : entityData) { + entries.put(data.entityType(), data.entityName()); + } + return new ClientQuotaEntity(Collections.unmodifiableMap(entries)); + } + + public List<ValueData> toDescribeValues() { + List<ValueData> values = new ArrayList<>(); + for (Entry<String, Double> entry : quotas.entrySet()) { + values.add(new ValueData().setKey(entry.getKey()).setValue(entry.getValue())); + } + return values; + } + + public boolean isEmpty() { + return quotas.isEmpty(); + } + + @Override + public boolean equals(Object o) { + if (!(o instanceof ClientQuotaImage)) return false; Review comment: The `equals` implementations are only used in unit tests currently, so maybe best to keep it simple for now? I really wish we had those Java 14 records classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
