dengziming commented on a change in pull request #10958:
URL: https://github.com/apache/kafka/pull/10958#discussion_r662895466
##########
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -315,6 +316,9 @@ private TopologyTestDriver(final InternalTopologyBuilder
builder,
configCopy.putIfAbsent(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG,
"dummy-bootstrap-host:0");
// provide randomized dummy app-id if it's not specified
configCopy.putIfAbsent(StreamsConfig.APPLICATION_ID_CONFIG,
"dummy-topology-test-driver-app-id-" + ThreadLocalRandom.current().nextInt());
+ // provide default serde since we change default serde to be null in
KIP-741
+ configCopy.putIfAbsent(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG,
Serdes.ByteArraySerde.class);
+ configCopy.putIfAbsent(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG,
Serdes.ByteArraySerde.class);
Review comment:
Thank you @cadonna , I also find a test
`ProcessorNodeTest#testTopologyLevelConfigException` should fail on default
config, I moved `properties` to every releated test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
