izzyacademy commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-873238772
> @guozhangwang , Thank you for the PR! > > > > I had some comments about the unit tests. > > > > Yesterday during our discussion, I forgot to also mention `JoinWindows` besides `SessionWindows` and `TimeWindows`. I think, we need to fix them also. Is this correct, @mjsax? I have a similar question as well @mjsax @ableegoldman I wonder if JoinWindows and SlidingWindows should be included as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
