skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663421545



##########
File path: 
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##########
@@ -214,6 +321,10 @@ public Errors error() {
         return responseData;
     }
 
+    public Map<TopicPartition, PartitionData> responseData(String groupId) {

Review comment:
       I am planning on changing this method to check and see if 
`groupToPartitionData` is empty. If it is empty we are using a version less 
than the one that supports batching and it will fall back to the old behavior. 
If not we know the response is initialized with data that supports batching and 
then it returns from the information from `groupToPartitionData`. Do you think 
this will be sufficient?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to