skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664703667
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##########
@@ -174,6 +315,28 @@ public boolean isAllPartitions() {
return data.topics() == ALL_TOPIC_PARTITIONS;
}
+ public boolean isAllPartitionsForGroup(String groupId) {
+ OffsetFetchRequestGroup group = data
+ .groupIds()
+ .stream()
+ .filter(g -> g.groupId().equals(groupId))
+ .collect(toSingleton());
Review comment:
Not sure I follow - are you saying that if there is a group that is
included multiple times in the request the `stream()` here would throw an
`IllegalStateException`? Are you saying we should put a `try...catch` statement
here to catch any `IllegalStateException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
