ableegoldman commented on a change in pull request #10985:
URL: https://github.com/apache/kafka/pull/10985#discussion_r665240093
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java
##########
@@ -555,7 +558,7 @@ public void
testLargeAssignmentAndGroupWithUniformSubscription() {
assignor.assign(partitionsPerTopic, subscriptions);
}
- @Timeout(40)
+ @Timeout(60)
Review comment:
Saw this fail sometimes when running locally. This PR definitely should
not have significantly affected the performance of this test in any way, since
the only substantial changes are in the constrained assignment algorithm, while
this test targets the general case of unequal subscriptions. It's not too
surprising to me that this would be running up against the time limit anyways,
since we've known that the general assignment algorithm is complicated and
doesn't scale too well.So I felt it was reasonable to give it a bit more time.
Alternatively we could just scale back a bit with the number of partitions
and/or consumers. WDYT @showuon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
