mattwong949 commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r666406571
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -156,13 +161,27 @@ public void ensureValid() {
}
/**
- * Get the timestamp of the first record in this batch. It is always the
create time of the record even if the
+ * Gets the base timestamp of the batch which is used to calculate the
timestamp deltas.
+ *
+ * @return The base timestamp or
+ * {@link RecordBatch#NO_TIMESTAMP} if the batch is empty
+ */
+ public long baseTimestamp() {
+ return buffer.getLong(FIRST_TIMESTAMP_OFFSET);
+ }
+
+ /**
+ * Get the timestamp of the first record in this batch. It is usually the
create time of the record even if the
* timestamp type of the batch is log append time.
- *
- * @return The first timestamp or {@link RecordBatch#NO_TIMESTAMP} if the
batch is empty
+ *
+ * @return The first timestamp if a record has been appended, unless the
delete horizon has been set
+ * {@link RecordBatch#NO_TIMESTAMP} if the batch is empty or if
the delete horizon is set
*/
public long firstTimestamp() {
Review comment:
I've removed the firstTimestamp() method, which included some
modifications to the baseTimestamp() method and those test changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
