cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667726749
##########
File path:
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json
##########
@@ -29,6 +29,15 @@
"about": "null if the ISR didn't change; the new in-sync replicas
otherwise." },
{ "name": "Leader", "type": "int32", "default": "-2", "entityType":
"brokerId",
"versions": "0+", "taggedVersions": "0+", "tag": 1,
- "about": "-1 if there is now no leader; -2 if the leader didn't change;
the new leader otherwise." }
+ "about": "-1 if there is now no leader; -2 if the leader didn't change;
the new leader otherwise." },
+ { "name": "Replicas", "type": "[]int32", "default": "null", "entityType":
"brokerId",
+ "versions": "0+", "nullableVersions": "0+", "taggedVersions": "0+",
"tag": 2,
+ "about": "null if the replicas didn't change; the new replicas
otherwise." },
+ { "name": "RemovingReplicas", "type": "[]int32", "default": "null",
"entityType": "brokerId",
Review comment:
null means that the PartitionChangeRecord didn't change it. That
possibility doesn't exist in PartitionRecord, which must spell out the full
values of all fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
