guozhangwang commented on pull request #10986: URL: https://github.com/apache/kafka/pull/10986#issuecomment-878589565
@hachikuji I think the key idea behind this fix is that, if a rebalance failed with e.g. memberId lost, then conceptually we would just started a new rebalance in which we would call `onJoinPrepare` and in which we may call `onRepartitionsRevoked` again. This behavior would be the same for eager or cooperative. Personally I think this fix is fine -- @ableegoldman if you could just add a unit test for the case of memberId lost during a first rebalance, and check that we would re-triggered `onJoinPrepare` again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
