ableegoldman commented on a change in pull request #10985:
URL: https://github.com/apache/kafka/pull/10985#discussion_r668406080
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##########
@@ -218,15 +256,14 @@ private boolean allSubscriptionsEqual(Set<String>
allTopics,
allRevokedPartitions.addAll(ownedPartitions.subList(minQuota,
ownedPartitions.size()));
// this consumer is potential maxQuota candidate since we're
still under the number of expected members
// with more than the minQuota partitions. Note, if the number
of expected members with more than
- // the minQuota partitions is 0, it means minQuota ==
maxQuota, so they won't be put into unfilledMembers
+ // the minQuota partitions is 0, it means minQuota ==
maxQuota, and there are no potentially unfilled
if (numMembersAssignedOverMinQuota <
expectedNumMembersAssignedOverMinQuota) {
- unfilledMembers.add(consumer);
+ potentiallyUnfilledMembersAtMinQuota.add(consumer);
Review comment:
Ack on the first two renamings, though I'd still want to prefix them
with `unfilled` to emphasize that these structures only hold members that may
potentially be assigned one or more partitions. ie, if `minQuota == maxQuota`,
then `potentiallyUnfilledMembersAtMinQuota` should actually be empty, in which
case `MembersWithExactMinQuotaPartitions` doesn't quite make sense. I'll
clarify this in the comments as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
