OmniaGM commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r668733930
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging {
formatter.configure(formatterArgs.asScala.asJava)
- val topicOrFilterOpt = List(topicOpt, whitelistOpt).filter(options.has)
- if (topicOrFilterOpt.size != 1)
- CommandLineUtils.printUsageAndDie(parser, "Exactly one of
whitelist/topic is required.")
+ val filterOpts = List(includeOpt, whitelistOpt).filter(options.has)
+ if (filterOpts.size == 2) {
+ CommandLineUtils.warn("--whitelist is DEPRECATED and ignored if
--include specified.")
Review comment:
@dajac not sure if we should do this. With other deprecated arguments we
simply ignore the deprecated one, if the new one specified. for example I can
see that `--broker-list` is simple ignored if `--bootstrap-server` specified in
`ConsoleProducer`, `VerifiableConsumer`, `VerifiableProducer` and
`GetOffsetShell`. And the scripts don't fail if both deprecated and new one
existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
