tombentley commented on a change in pull request #11006:
URL: https://github.com/apache/kafka/pull/11006#discussion_r668888179



##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -406,6 +398,18 @@ class LogManager(logDirs: Seq[File],
     info(s"Loaded $numTotalLogs logs in ${time.hiResClockMs() - startMs}ms.")
   }
 
+  private def logDirExecutor(logDirAbsolutePath: String, threadNamePrefix: 
String): ExecutorService = {
+    Executors.newFixedThreadPool(numRecoveryThreadsPerDataDir, new 
ThreadFactory {

Review comment:
       Yeah, that's much better, thanks! I've inlined the method because it 
didn't add much. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to