vamossagar12 commented on a change in pull request #10877:
URL: https://github.com/apache/kafka/pull/10877#discussion_r669539634
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MemoryNavigableLRUCache.java
##########
@@ -66,6 +68,20 @@ public MemoryNavigableLRUCache(final String name, final int
maxCacheSize) {
.subMap(from, true, to, true).descendingKeySet().iterator(),
treeMap));
}
+ @Override
+ public <PS extends Serializer<P>, P> KeyValueIterator<Bytes, byte[]>
prefixScan(final P prefix, final PS prefixKeySerializer) {
Review comment:
1) I guess the reason I didn't add test in `InMemoryLRUCacheStoreTest`
was that the key type defined here is Integer and prefixScan like
range/reverseRange relies on byte lexicographical ordering and not on the
ordering of the key type. So, IMO this test won't yield much for this case. If
needed, I can add it.But, I think the tests for reverse and reverseRange are
also missing from this class for the same reason or it could just be a miss :)
2) Regarding the merging of test classes into one, I see that both those
classes override the `createKeyValueStore` method differently, so merging them
as per me would need some analysis. Is it ok if we create a separate ticket and
tackle it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
