ijuma commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r670557926
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -253,9 +259,10 @@ class LogManager(logDirs: Seq[File],
hadCleanShutdown: Boolean,
recoveryPoints: Map[TopicPartition, Long],
logStartOffsets: Map[TopicPartition, Long],
+ defaultConfig: LogConfig,
topicConfigOverrides: Map[String, LogConfig]): Log
= {
val topicPartition = Log.parseTopicPartitionName(logDir)
- val config = topicConfigOverrides.getOrElse(topicPartition.topic,
currentDefaultConfig)
+ val config = topicConfigOverrides.getOrElse(topicPartition.topic,
defaultConfig)
Review comment:
Regarding `currentDefaultConfig`, the answer is yes for `LogManager`.
There is one case in `DynamicBrokerConfig` that could be handled better, I'll
submit a separate PR for that (it's unrelated to the changes here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
