C0urante commented on a change in pull request #10563:
URL: https://github.com/apache/kafka/pull/10563#discussion_r671406780
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/WorkerErrantRecordReporter.java
##########
@@ -49,7 +54,7 @@
private final HeaderConverter headerConverter;
// Visible for testing
- protected final LinkedList<Future<Void>> futures;
+ protected final Map<TopicPartition, Future<Void>> futures;
Review comment:
I like this style and agree with the suggestion; however, there's
actually a bug in the PR right now where we only store one `Future` at a time
per topic-partition, so will address in a follow-up commit instead of just
clicking the `Commit suggestion` button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
