ijuma commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r671608959
##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -479,4 +501,31 @@ object LogConfig {
logProps.put(MessageDownConversionEnableProp,
kafkaConfig.logMessageDownConversionEnable: java.lang.Boolean)
logProps
}
+
+ def shouldIgnoreMessageFormatVersion(interBrokerProtocolVersion:
ApiVersion): Boolean =
+ interBrokerProtocolVersion >= KAFKA_3_0_IV1
Review comment:
On second thought, this is going to be very confusing since we already
have `3.1-IV0`. I think we're better off just going with `3.0-IV1`. The change
here is benign in general and the IBP check is us being super careful. The
number of people using IBP `3.0-IV1` is probably 0, but if there are some, they
are not likely to be using the ancient record formats 0 and 1 in such clusters
for new records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
