jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r671754759
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -758,16 +814,25 @@ class FetchManager(private val time: Time,
case Some(session) => session.synchronized {
if (session.epoch != reqMetadata.epoch) {
debug(s"Session error for ${reqMetadata.sessionId}: expected
epoch " +
- s"${session.epoch}, but got ${reqMetadata.epoch} instead.");
+ s"${session.epoch}, but got ${reqMetadata.epoch} instead.")
new SessionErrorContext(Errors.INVALID_FETCH_SESSION_EPOCH,
reqMetadata)
+ } else if (session.usesTopicIds && reqVersion < 13 ||
!session.usesTopicIds && reqVersion >= 13) {
Review comment:
Changing the version is not allowed. I'm not sure I follow what you mean
by keeping version. Current usesTopicIds is set based on the version when the
session is first created and maintained throughout the session.
I think we will see this error transiently, but please let me know if you
continue to see this issue after I fix the bug below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
