tang7526 commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r671973575
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier
storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
@abbccdda It will throw a exception at line 38 if `storeSupplier ` is
null. So line 39 is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
