mjsax commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r672438866
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -655,7 +655,7 @@ public void doDelete(final List<String> topicsToDelete,
final Admin adminClient) {
boolean hasDeleteErrors = false;
final DeleteTopicsResult deleteTopicsResult =
adminClient.deleteTopics(topicsToDelete);
- final Map<String, KafkaFuture<Void>> results =
deleteTopicsResult.values();
+ final Map<String, KafkaFuture<Void>> results =
deleteTopicsResult.topicNameValues();
Review comment:
Thanks! Can we cross link KIP wiki page and Jiras to make it easier to
find?
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -655,7 +655,7 @@ public void doDelete(final List<String> topicsToDelete,
final Admin adminClient) {
boolean hasDeleteErrors = false;
final DeleteTopicsResult deleteTopicsResult =
adminClient.deleteTopics(topicsToDelete);
- final Map<String, KafkaFuture<Void>> results =
deleteTopicsResult.values();
+ final Map<String, KafkaFuture<Void>> results =
deleteTopicsResult.topicNameValues();
Review comment:
Thanks!
It's also best, to mention a KIP in the commit message. I guess @hachikuji
just forgot to add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
