jolshan commented on a change in pull request #11104:
URL: https://github.com/apache/kafka/pull/11104#discussion_r674387908
##########
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##########
@@ -332,6 +329,9 @@ public FetchRequestData build() {
iter.remove();
// Indicate that we no longer want to listen to this
partition.
removed.add(topicPartition);
+ // If we do not have this topic ID in the session, we can
not use topic IDs
Review comment:
One alternative to this approach is to only do this check when no
partitions were added to the builder, but I'm not sure this added complexity is
worth it. The method here is also safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
