hachikuji commented on a change in pull request #11108:
URL: https://github.com/apache/kafka/pull/11108#discussion_r674975130
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -785,7 +785,7 @@ class KafkaApis(val requestChannel: RequestChannel,
Some(RecordBatch.MAGIC_VALUE_V1)
else
None
- }
+ }.filter(_ => unconvertedRecords.batchIterator.hasNext)
Review comment:
This is fine I guess, but it kind of feels like we should fix the
down-conversion code if it is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
