jolshan opened a new pull request #11126:
URL: https://github.com/apache/kafka/pull/11126


   As described in the ticket, in 3.0 there was a change that resulted in no 
longer assigning topic IDs to the log and the partition.metadata file in 
certain upgrade scenarios. This PR adds a check for whether we need to handle 
the LISR request given a new topic ID when one is not yet assigned in the log 
and code to assign a topic ID when the log is already associated to a partition 
in ReplicaManager.
   
   The idea is that we may need to handle one extra LISR request per partition 
when we are upgrading to using topic IDs. Steady state, we should not have this 
issue.
   
   I've added a test for the upgrade scenario that would have replicated the 
gap before this fix. (The test fails on master)
   
   I've also revised some replicamanager tests that will now fail with 
inconsistent topic IDs unless we use the correct topic ID.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to