cmccabe edited a comment on pull request #10951: URL: https://github.com/apache/kafka/pull/10951#issuecomment-887023640
If I understand correctly, the PR makes up a fake partition so that `TopicPartition` can be non-null in the callback. I don't think that this is the right thing to do. Why not change the JavaDoc for the callback to indicate that `TopicPartition` can be null if the method fails before it gets assigned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
