ableegoldman commented on pull request #11124: URL: https://github.com/apache/kafka/pull/11124#issuecomment-887994503
It seems super awkward and likely to lead to confusion/future mistakes to use something called a `"SessionWindow"` in the "SlidingWindowAggregate", although yeah, it's pretty much exactly the same otherwise and can be reused. In other words, I totally agree with your proposal to just rename the existing Window implementations to describe the actual interval they represent, rather than some specific type of windowed operation that just happens to use them at the moment. (In fact I had written that first paragraph before I even saw your comment with the renaming proposal, great minds think alike huh 😜) That said, those names are just super clunky. Imagine trying to code something up with that...just takes too much mental processing. Maybe it's my inner physicist, but sometimes mathematical precision just isn't appropriate for real-world usage (don't tell any mathematicians I said that!) Unfortunately I'm not crazy about any of the alternatives I can think up, maybe you can come up with some better ideas. Here's the best I could come up with: `TimeWindow` --> `InclusiveExclusiveWindow` `SessionWindow` / `SlidingWindow` --> `InclusiveInclusiveWindow` `UnlimitedWindow` --> `InclusiveUnboundedWindow` To me at least these feel more natural, ie it's clear what they mean without having to reference Wikipedia. I mean most people probably do know what open/closed mean, but inclusive/exclusive is more to the point. Also I think we can drop left/right and just imply it by the ordering. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
