hachikuji commented on a change in pull request #11140:
URL: https://github.com/apache/kafka/pull/11140#discussion_r679314640
##########
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##########
@@ -247,7 +247,7 @@ abstract class AbstractFetcherThread(name: String,
val highWatermark = partitionState.fetchOffset
val truncationState = OffsetTruncationState(highWatermark,
truncationCompleted = true)
- info(s"Truncating partition $tp to local high watermark
$highWatermark")
+ info(s"Truncating partition $tp to $truncationState due to local high
watermark $highWatermark")
Review comment:
nit: the `toString` for `OffsetTruncationState` is a little
unconventional. Maybe we could replace it with something like this:
```scala
override def toString: String = s"TruncationState(offset=$offset,
completed:$truncationCompleted)"
```
Then we can change this from "to" to "with" so the message reads (e.g.):
> Truncating partition foo-0 with TruncationState(offset=19, completed=true)
based on local high watermark 19.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
