vincent81jiang commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r679346836
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##########
@@ -239,9 +249,68 @@ private static FilterResult filterTo(TopicPartition
partition, Iterable<MutableR
return filterResult;
}
+ private static BatchFilterResult filterBatch(RecordBatch batch,
+ BufferSupplier
decompressionBufferSupplier,
+ FilterResult filterResult,
+ RecordFilter filter,
+ byte batchMagic,
+ boolean writeOriginalBatch,
+ long maxOffset,
Review comment:
Looks like maxOffset is always initialized to -1? If so, we can remove
it from input parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
