hachikuji commented on a change in pull request #10909:
URL: https://github.com/apache/kafka/pull/10909#discussion_r679390697
##########
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##########
@@ -186,13 +186,18 @@ class KafkaRaftManager[T](
records: Seq[T],
isAtomic: Boolean
): Option[Long] = {
- val offset = if (isAtomic) {
- client.scheduleAtomicAppend(epoch, records.asJava)
- } else {
- client.scheduleAppend(epoch, records.asJava)
+ try {
Review comment:
I'm looking into the usages here. It looks like we have no uses for
`RaftManager.scheduleAtomicAppend` and the only use of `scheduleAppend` is in
`TestRaftServer`. Maybe we can remove these two methods and change
`TestRaftServer` to write to the client directly (since it is exposed by
`RaftManager` already).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
