ableegoldman commented on a change in pull request #10788:
URL: https://github.com/apache/kafka/pull/10788#discussion_r682238334
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -248,12 +249,29 @@ public ByteBuffer subscriptionUserData(final Set<String>
topics) {
handleRebalanceStart(topics);
uniqueField++;
+ final Set<String> currentNamedTopologies;
+ final Map<TaskId, Long> taskOffsetSums;
+ try {
+ taskManager.topologyMetadata().lock();
Review comment:
The lock was less for thread-safety purposes and more about atomicity
w.r.t updating some bookkeeping/state. But I guess I removed a lot of that
bookkeeping recently, so I'll do another pass and clean up this handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
