showuon commented on a change in pull request #11218: URL: https://github.com/apache/kafka/pull/11218#discussion_r690007620
########## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ########## @@ -48,6 +53,16 @@ public class ConsumerConfig extends AbstractConfig { private static final ConfigDef CONFIG; + // a list contains all the in-product assignor names. Should be updated when new assignor added. + // This is to help optimize the ConsumerCoordinator#performAssignment + public static final List<String> IN_PRODUCT_ASSIGNOR_NAMES = + Collections.unmodifiableList(Arrays.asList( + RANGE_ASSIGNOR_NAME, + ROUNDROBIN_ASSIGNOR_NAME, + STICKY_ASSIGNOR_NAME, + COOPERATIVE_STICKY_ASSIGNOR_NAME Review comment: Question: Should we add `StreamsPartitionAssignor` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org